Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NayNay] Exposing substrate #435

Merged
merged 5 commits into from
Dec 2, 2024
Merged

[NayNay] Exposing substrate #435

merged 5 commits into from
Dec 2, 2024

Conversation

rh0delta
Copy link
Contributor

Related Issue(s)

Proposed Changes

  • added new utility method to create substrate api instance, without needing to create an entropy instance

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed

Screenshots (if applicable)

Additional Context

Checklist

  • I have performed a self-review of my code.
  • I have commented my code.
  • I have updated documentation, where necessary.

- added new utility method to create substrate api instance, without needing to create an entropy instance
@rh0delta rh0delta added the documentation Improvements or additions to documentation label Nov 22, 2024
src/utils/index.ts Outdated Show resolved Hide resolved
src/utils/index.ts Show resolved Hide resolved
src/utils/index.ts Outdated Show resolved Hide resolved
@frankiebee
Copy link
Collaborator

frankiebee commented Nov 22, 2024

I'd like a little more documentation for this pointing at the polkadot docs to communicate that we don't maintain the underlying api for substrate and a warning that this might change in the future

@rh0delta rh0delta added the blocked can not be worked on yet label Nov 22, 2024
@rh0delta rh0delta removed the blocked can not be worked on yet label Dec 2, 2024
@frankiebee
Copy link
Collaborator

I'd like a little more documentation for this pointing at the polkadot docs to communicate that we don't maintain the underlying api for substrate and a warning that this might change in the future

will handle with this issu: #436

Copy link
Collaborator

@frankiebee frankiebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweeet

@frankiebee frankiebee merged commit ce96745 into main Dec 2, 2024
3 checks passed
@frankiebee frankiebee deleted the naynay/expose-substrate branch December 2, 2024 22:03
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose substrate as part of the Entropy Class rather than the Entropy Instance
2 participants