Return Option in more places #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(blanket impl is enough). Move the from_xoff impl to a new `misc` module. Revert the `bound_bits` arg to be usize
Impl ToMod for some U<…> (512-4096)
Adding the from_xoff code to a `misc` module
Dummy impl of HasWide for U8192 Cleanup and low-hanging fruit
Complete the PartialOrd impl Fix a off-by-one bug in random_bounded
Add tests and comment about the unusual behaviour of Add for Signed Impl PartialOrd/Eq to ignore the bound
around bounds when multiplying (checked/wide)
Add tests for Signed::mul_wide and checked_mul
Clippy fixes
Misc review feedback
Add Bounded::into_inner
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #147 +/- ##
==========================================
- Coverage 93.16% 93.14% -0.02%
==========================================
Files 43 43
Lines 8101 8113 +12
==========================================
+ Hits 7547 7557 +10
- Misses 554 556 +2 ☔ View full report in Codecov by Sentry. |
fjarri
force-pushed
the
dp-error-handling
branch
from
70b072d to
0b03b43
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting out some places where we
unwrap.Partially fixes #76
Builds upon #120, hence the noise and why it's kept as draft.