Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return all RustCrypto libs but crypto-bigint to stable versions #154

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 17, 2024

This will make it possible for entropy-core to still use our master branch. crypto-bigint can stay at the pre-release since it is not directly exposed to the user.

@fjarri fjarri requested a review from dvdplm October 17, 2024 01:20
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 93.13%. Comparing base (9e24b37) to head (7f9400e).

Files with missing lines Patch % Lines
synedrion/src/cggmp21/params.rs 90.32% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   93.16%   93.13%   -0.03%     
==========================================
  Files          43       43              
  Lines        8101     8112      +11     
==========================================
+ Hits         7547     7555       +8     
- Misses        554      557       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dvdplm
Copy link
Contributor

dvdplm commented Oct 17, 2024

Code LGTM.

I wonder though if core should depend on master. Aren't they better off using a tag or a branch? Right now they are using 0.2.0-beta.0 (which I think correspond to release/v0.2.0-pre.0 but I'm not actually sure) and that seems like the right thing to do.

I suggest we do this:

  1. Make sure we know which tag corresponds to 0.2.0-beta.0
  2. Review&merge the open PRs (or reject&close ofc)
  3. Merge this PR
  4. Cut a new release 0.2.0-pre.1 with (mostly) stable RC crates

@fjarri
Copy link
Member Author

fjarri commented Oct 17, 2024

I guess what I meant was that we won't have to maintain two separate branches and backport changes/fixes, and entropy-core will be able to depend on the releases made on master.

@fjarri fjarri merged commit 6bac5fa into entropyxyz:master Oct 18, 2024
4 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
@fjarri fjarri deleted the stable-libs branch October 18, 2024 00:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants