Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch protocol framework to manul #156

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Oct 26, 2024

Fixes #151

As discussed in Slack, it's quite tricky to keep Presigning and Signing separate - if an error happens in Signing it requires a bunch of signed messages from Presigning, and it's very awkward to keep and supply them. So this PR merges Presigning and Signing.

If we ever need a separate Presigning, the 6-round version from the paper will be suitable, since its Signing counterpart does not require us to transfer any Presigning messages. See #36.

Even though the code is still kind of dirty, this PR is so huge I think it should just stop here. The cleanup will be made in subsequent PRs. We didn't introduce any new unfinished parts, all the unimplemented stuff has already been there before.

Update: the new version of CGGMP paper resolves this by moving all the required proofs into Presigning, but I would rather not modify this PR any more, and there's also another one stacked on top of it. The Presigning and Signing will be split again in the course of fixing #157

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 84.42450% with 295 lines in your changes missing coverage. Please review.

Project coverage is 92.59%. Comparing base (844a7ea) to head (90ccb70).

Files with missing lines Patch % Lines
...drion/src/cggmp21/protocols/interactive_signing.rs 84.97% 148 Missing ⚠️
synedrion/src/cggmp21/protocols/key_refresh.rs 79.01% 47 Missing ⚠️
synedrion/src/cggmp21/protocols/aux_gen.rs 80.09% 41 Missing ⚠️
synedrion/src/cggmp21/protocols/key_init.rs 84.44% 28 Missing ⚠️
synedrion/src/www02/key_resharing.rs 86.09% 26 Missing ⚠️
synedrion/src/tools/hide_debug.rs 69.23% 4 Missing ⚠️
synedrion/src/cggmp21/entities.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
- Coverage   93.12%   92.59%   -0.53%     
==========================================
  Files          43       33      -10     
  Lines        8130     6661    -1469     
==========================================
- Hits         7571     6168    -1403     
+ Misses        559      493      -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@fjarri fjarri marked this pull request as ready for review November 16, 2024 02:59
@fjarri fjarri requested a review from dvdplm November 16, 2024 02:59
@fjarri fjarri mentioned this pull request Nov 17, 2024
@fjarri fjarri merged commit 4a62fae into entropyxyz:master Nov 19, 2024
4 of 6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
@fjarri fjarri deleted the manulization branch November 19, 2024 20:25
@dvdplm
Copy link
Contributor

dvdplm commented Nov 19, 2024

Fair enough!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manulization
2 participants