-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for CGGMP'24: Paillier/ring-Pedersen level #161
Conversation
2382fe6
to
551cd54
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #161 +/- ##
==========================================
+ Coverage 92.21% 92.36% +0.14%
==========================================
Files 33 35 +2
Lines 6422 6534 +112
==========================================
+ Hits 5922 6035 +113
+ Misses 500 499 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left a few comments and nitpicks. At the end of the day I think using "wire" is probably fine, but I don't love it and think that the previous names were mostly ok and quite readable.
The problem with the previous names was that the most used ones were also very long and had suffixes that had to be repeated everywhere. The goal was to make it so that one could use |
Merging this for now to free the way for #163, we can work on naming in a separate PR. |
Part of #157
SecretPrimes
/PublicModulus
. Note that according to the new version of the paper Paillier only needsmod 3 = 4
primes, while ring-Pedersen needs safe primes.Exponentiable
where approriatepaillier
. Namely: the wire ones have the "Wire" postfix, the expanded ones have no postfixes. The conversion methods areto_wire()
andto_precomputed()
.u32
to matchcrypto-bigint
The new
Secret
will be properly used throughout the codebase in a follow-up PR, this one is getting pretty big already.