Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move around internal submodules for a more logical structure #97

Merged
merged 3 commits into from
Jan 17, 2024

Conversation

fjarri
Copy link
Member

@fjarri fjarri commented Jan 16, 2024

  • Moved typed rounds machinery into its own submodule (rounds), to be used by cggmp21 and www02 (or whatever key resharing protocol we may implement later)
  • Moved the key resharing protocol to www02 submodule, on the same level with cggmp21.
  • Move session constructors to the top level out of the sessions submodule (which is a dynamic equivalent of rounds and shouldn't contain any protocol-specific things)

Copy link

vercel bot commented Jan 16, 2024

@fjarri is attempting to deploy a commit to the entropyxyz Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
synedrion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 11:56pm

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (3b789b0) 87.13% compared to head (781cf5c) 87.13%.

Files Patch % Lines
synedrion/src/sessions/states.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          45       45           
  Lines        7251     7251           
=======================================
  Hits         6318     6318           
  Misses        933      933           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fjarri fjarri marked this pull request as ready for review January 17, 2024 21:57
@fjarri fjarri merged commit 1e8f908 into entropyxyz:master Jan 17, 2024
7 of 8 checks passed
@fjarri fjarri deleted the modules branch January 17, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant