Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Ubuntu container to 22.04 #302

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vasilvv
Copy link

@vasilvv vasilvv commented Nov 29, 2023

No description provided.

@vasilvv vasilvv requested a review from a team as a code owner November 29, 2023 00:41
Signed-off-by: Victor Vasiliev <[email protected]>
@phlax
Copy link
Member

phlax commented Nov 29, 2023

iiuc this will change which distros we can support - ie it will make the envoy binary that is produced incompatible with more distro/versions

cc @lizan

@RyanTheOptimist
Copy link

iiuc this will change which distros we can support - ie it will make the envoy binary that is produced incompatible with more distro/versions

cc @lizan

What do we need to do to make forward progress on this? This change will allow us to get C++20 support in Envoy, which is required for at least the Google URL dependency.

@phlax
Copy link
Member

phlax commented Dec 4, 2023

What do we need to do to make forward progress on this?

well iiuc then there is not much we can do other than create some path/code for legacy toolchains - this would already be a great thing and would resolve a bunch of tangentially related issues, but its not trivial

without that its more of a political decision about when we stop supporting which distro/versions

@RyanTheOptimist
Copy link

What do we need to do to make forward progress on this?

well iiuc then there is not much we can do other than create some path/code for legacy toolchains - this would already be a great thing and would resolve a bunch of tangentially related issues, but its not trivial

without that its more of a political decision about when we stop supporting which distro/versions

What if we only used the new 22.04 image for gcc CI, but use the old imagine for everything else? Would that help?

@phlax
Copy link
Member

phlax commented Dec 4, 2023

What if we only used the new 22.04 image for gcc CI, but use the old imagine for everything else? Would that help?

with current setup it would mean separating images/build/etc and corresponding images in envoy

@RyanTheOptimist
Copy link

What if we only used the new 22.04 image for gcc CI, but use the old imagine for everything else? Would that help?

with current setup it would mean separating images/build/etc and corresponding images in envoy

Would that be easier/better than trying to just use 22.04 for everything?

@phlax
Copy link
Member

phlax commented Dec 4, 2023

Would that be easier/better than trying to just use 22.04 for everything?

if we want to support multiple toolchains its not going to be easy whatever way we do it - either in terms of setup or maintenance

i think there is a ~right way to do this - not that i necessarily know it at this point, and probs that is the way to pursue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants