Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add http server test #134

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

helight
Copy link

@helight helight commented Sep 29, 2020

  1. Add an http server for testing http filter.
  2. Add config.yaml for testing http filter.
  3. Add readme for testing http filter instruction.

@helight
Copy link
Author

helight commented Sep 29, 2020

@lizan please help to review this pr

Copy link
Member

@lizan lizan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some sort of test for this config? Like verify examples in envoy repo.

@@ -48,12 +48,40 @@ http_filters:
- name: sample # before envoy.router because order matters!
typed_config:
"@type": type.googleapis.com/sample.Decoder
key: via
key: Via
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: keep this lowercase

Copy link
Author

@helight helight Sep 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for testing this function
http_filter.cc

const LowerCaseString HttpSampleDecoderFilter::headerKey() const {
  return LowerCaseString(config_->key());
}

@helight
Copy link
Author

helight commented Sep 30, 2020

Can we have some sort of test for this config? Like verify examples in envoy repo.

Ok

Signed-off-by: helight <[email protected]>
@helight
Copy link
Author

helight commented Oct 6, 2020

Can we have some sort of test for this config? Like verify examples in envoy repo.

@lizan I add a startup.sh and verify.sh, please help to check

Base automatically changed from master to main January 15, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants