feature: adds support for go-control-plane based xDS implementations #41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 This proposal adds support for OSS implementations of the xDS control plane.
Kindly let me know whether this is something you would like integrated into envoy-tools/csds-client, and what are your thoughts on this approach.
platform
go
This patch adds support for a second type of platform, named
go
. It does so by providing utility functionConnToXDS
andDialOptions
to initiate gRPCs to the address specified by the flagservice_uri
.authentication options for platform
go
Support is added for mTLS via the introduction of the following new flags:
The the client certificate/private key pair are included in the ClientHello message for establishing a connection over TLS.
If a certificate authority is provided via
cacert
, it is used to validate the server's certificate identity.Additionally, the
-authority
flag allows for setting the HTTP/2:authority
header to use for SNI.Example
Click to expand response output
Testing coverage
The patch does not include any additional tests. The various test functions in the
client/v2
andclient/v3
seem to cover the existing utility functions (for parsing and printing out detailed responses) with golden JSON data files.The part that I think would benefit from a unit test is the
DialOptions
functions that configures the HTTP/2 connection depending on the provided command-line flags for authentication.Best,
Owayss.