Skip to content

Commit

Permalink
mobile: Disable ClientIntegrationTest.DisableDnsRefreshOnFailure on m…
Browse files Browse the repository at this point in the history
…acOS (#38282)

The DNS refresh on failure currently only works for `getaddrinfo` on
Linux because the Apple DNS resolver treats
`kDNSServiceErr_NoSuchRecord` as non-failure.

Risk Level: low (test only)
Testing: integration test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

---------

Signed-off-by: Fredy Wijaya <[email protected]>
fredyw authored Jan 31, 2025
1 parent f683f26 commit 2efb366
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions mobile/test/common/integration/client_integration_test.cc
Original file line number Diff line number Diff line change
@@ -262,6 +262,9 @@ TEST_P(ClientIntegrationTest, BasicWithCares) {
}
#endif

// TODO(fredyw): Disable this until we support treating no DNS record as a failure in the Apple
// resolver.
#if not defined(__APPLE__)
TEST_P(ClientIntegrationTest, DisableDnsRefreshOnFailure) {
builder_.setLogLevel(Logger::Logger::debug);
std::atomic<bool> found_cache_miss{false};
@@ -290,6 +293,7 @@ TEST_P(ClientIntegrationTest, DisableDnsRefreshOnFailure) {

EXPECT_TRUE(found_cache_miss);
}
#endif

TEST_P(ClientIntegrationTest, LargeResponse) {
initialize();

0 comments on commit 2efb366

Please sign in to comment.