mobile: Disable ClientIntegrationTest.DisableDnsRefreshOnFailure on m…

…acOS (#38282) The DNS refresh on failure currently only works for `getaddrinfo` on Linux because the Apple DNS resolver treats `kDNSServiceErr_NoSuchRecord` as non-failure. Risk Level: low (test only) Testing: integration test Docs Changes: n/a Release Notes: n/a Platform Specific Features: n/a --------- Signed-off-by: Fredy Wijaya <[email protected]>
envoyproxy · Jan 31, 2025 · 2efb366 · 2efb366
1 parent f683f26
commit 2efb366
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/mobile/test/common/integration/client_integration_test.cc b/mobile/test/common/integration/client_integration_test.cc
@@ -262,6 +262,9 @@ TEST_P(ClientIntegrationTest, BasicWithCares) {
 }
 #endif
 
+// TODO(fredyw): Disable this until we support treating no DNS record as a failure in the Apple
+// resolver.
+#if not defined(__APPLE__)
 TEST_P(ClientIntegrationTest, DisableDnsRefreshOnFailure) {
   builder_.setLogLevel(Logger::Logger::debug);
   std::atomic<bool> found_cache_miss{false};
@@ -290,6 +293,7 @@ TEST_P(ClientIntegrationTest, DisableDnsRefreshOnFailure) {
 
   EXPECT_TRUE(found_cache_miss);
 }
+#endif
 
 TEST_P(ClientIntegrationTest, LargeResponse) {
   initialize();