Skip to content

Commit

Permalink
tools/deprecate_guards: Fix error handling (#38006)
Browse files Browse the repository at this point in the history
Signed-off-by: Ryan Northey <[email protected]>
  • Loading branch information
phlax authored Jan 15, 2025
1 parent 7b2a784 commit 435d96b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/deprecate_guards/deprecate_guards.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ async def create_issue(self, title: str, body: str, login: str) -> None:
else:
self.log.warning(f"Dry run: not creating issue '{title}' for {login}")
return
except gidgethub.Exception:
except gidgethub.GitHubException:
self.log.warning(
f"unable to assign issue {title} to {login}. Add them to the Envoy proxy org"
"and assign it their way.")
Expand All @@ -195,7 +195,7 @@ async def create_issue(self, title: str, body: str, login: str) -> None:
self.log.notice(f"Created issue '{title}'{extra_log}")
else:
self.log.warning(f"Dry run: not creating issue '{title}'{extra_log}")
except gidgethub.Exception as e:
except gidgethub.GitHubException as e:
self.log.error("Github error while creating issue.\n{e}")
raise DeprecateGuardsError(e)

Expand Down

0 comments on commit 435d96b

Please sign in to comment.