wasm: update V8 to 9.6.152 #18375
Closed
wasm: update V8 to 9.6.152 #18375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current (v9.2.230.13) contain bug which doesn't let build envoy on centos 7 Signed-off-by: Bart Smykla <[email protected]>
|
Hi @bartsmykla, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
repokitteh-read-only
bot
added
the
deps
PiotrSikora
reviewed
Oct 14, 2021
There was a problem hiding this comment.
I opened a PR with update to v9.5 (#18621), since it was a bit more involved than a version bump due to addition of a semi-complete Bazel support in v9.3.
| @@ -808,14 +808,14 @@ REPOSITORY_LOCATIONS_SPEC = dict( | |||
| project_name = "V8", | |||
| project_desc = "Google’s open source high-performance JavaScript and WebAssembly engine, written in C++", | |||
| project_url = "https://v8.dev", | |||
| version = "9.2.230.13", | |||
| version = "9.6.152", | |||
There was a problem hiding this comment.
v9.6 didn't reach chromium beta channel yet, so it might be a bit too early for that.
There was a problem hiding this comment.
got it, thank you for the PR - I'm closing this one then :-)
|
I'm closing this PR. Thank you for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging this PR, someone with proper access (@PiotrSikora maybe?) should deploy artifacts built by https://storage.googleapis.com/envoyproxy-wee8/wee8-archive.sh to https://storage.googleapis.com/envoyproxy-wee8/wee8-9.6.152.tar.gz
Commit Message: wasm: The current (v9.2.230.13) contain bug which doesn't let build
envoy on centos 7
Additional Description: none
Risk Level: it's hard to asses by me as I don't have a lot of experience with v8 and couldn't find a good amount of information of changes between these versions
Testing: CI build checks
Docs Changes: none
Release Notes: none
Platform Specific Features: none
Fixes #18365