Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Cleanup version histories #20961

Merged
merged 1 commit into from
Apr 25, 2022

Conversation

phlax
Copy link
Member

@phlax phlax commented Apr 24, 2022

Signed-off-by: Ryan Northey [email protected]

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Fix #20963
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft April 24, 2022 11:17
@phlax phlax force-pushed the docs-version-history-cleanups branch 3 times, most recently from e967b63 to 00e7291 Compare April 24, 2022 12:30
@phlax
Copy link
Member Author

phlax commented Apr 24, 2022

@phlax
Copy link
Member Author

phlax commented Apr 25, 2022

this will conflict with #20958

/wait

@phlax phlax force-pushed the docs-version-history-cleanups branch from 6c1635d to 6a0e78f Compare April 25, 2022 10:21
@phlax phlax changed the title [WIP] docs: Cleanup version histories docs: Cleanup version histories Apr 25, 2022
@phlax phlax marked this pull request as ready for review April 25, 2022 10:21
@phlax
Copy link
Member Author

phlax commented Apr 25, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #20961 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Member Author

phlax commented Apr 25, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #20961 (comment) was created by @phlax.

see: more, trace.

@alyssawilk alyssawilk self-assigned this Apr 25, 2022
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have a step in the release which adds these prefixes? right now we just copy current to version.number.rst

@phlax
Copy link
Member Author

phlax commented Apr 25, 2022

should we have a step in the release which adds these prefixes? right now we just copy current to version.number.rst

probably yes

rst is not the easiest thing to parse and replace with, i think its doable but not trivial

@alyssawilk
Copy link
Contributor

eh, even if we say "do it manually" it's better than you doing it every few months. cc @RyanTheOptimist who can maybe include it when he moves things from governance to releases

@phlax
Copy link
Member Author

phlax commented Apr 25, 2022

even if we say "do it manually"

ah yep, my brain is just in what-can-be-automated mode

@phlax phlax merged commit 331fabc into envoyproxy:main Apr 25, 2022
@phlax
Copy link
Member Author

phlax commented Apr 26, 2022

should we have a step in the release which adds these prefixes?

following up on this - it needs to happen at the correct time and for the correct docs...

i have posted a lengthier description of the current steps that are afaict required here #20851 (comment)

ravenblackx pushed a commit to ravenblackx/envoy that referenced this pull request Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intersphinx mapping is not enforcing local refs strictly
2 participants