ratelimit: masked_remote_address action don't return descriptor_entry with statsd key words #36275
Conversation
… with statsd key words Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
|
/retest |
| // For Ipv4, masked_address is returned in a format similar to '192.168.1.0/32', '.' It's a key | ||
| // word in statsd, This makes it difficult to export measurements in Promethean format in the | ||
| // RateLimit server. | ||
| masked_address = absl::StrReplaceAll(masked_address, {{".", "_"}}); |
There was a problem hiding this comment.
This seems like it might be a breaking change for many people.
Envoy supports many consumers of stats and I feel like we shouldn't tweak naming in a common subsystem to tune to just one of them.
Regarding Prometheus: why not just generate Prom format directly? Why go via statsd?
There was a problem hiding this comment.
This seems like it might be a breaking change for many people.
we can either add a runtime feature flag or add an optional API field for this.
Envoy supports many consumers of stats and I feel like we shouldn't tweak naming in a common subsystem to tune to just one of them.
this problem mainly related to envoyproxy/ratelimit, I spend a lot of time in the past trying to bring native promemtheus to it but failed, becase it requires to change a lot of libs used by envoyproxy/ratelimit.
There was a problem hiding this comment.
I feel like this change is going to spawn a lot of other changes as well. THere are a ton of places where IP addresses and other things with dots show up in stat names and I'm unsure why this one is different.
There was a problem hiding this comment.
In general I'd like to see specific needs of individual sinks addressed in the sink, ideally, not in code that generates stat names that would also be used by other sinks.
There was a problem hiding this comment.
yes, you're right. After rethinking, any ratelimit action that support custom descriptor value will have same problem when user specify ..
let me try to fix this in evnoyproxy/ratelimit.
|
/wait |
|
superseded by envoyproxy/ratelimit#716 |
Commit Message: For envoyproxy/gateway#4281, descriptor_entry with
.make it's hard to export metric in prometheus in RateLimit server.Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]