Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the do_ci.sh script for refreshing the compilation database #37668

Merged
merged 3 commits into from
Jan 6, 2025

use do_ci.sh in the pre-push git hook

69898bd
Select commit
Loading
Failed to load commit list.
Merged

Use the do_ci.sh script for refreshing the compilation database #37668

use do_ci.sh in the pre-push git hook
69898bd
Select commit
Loading
Failed to load commit list.
CI (Envoy) / Mobile/Android skipped Dec 22, 2024 in 0s

Check was skipped

This check was not triggered in this CI run

Details

Request (pr/37668/main@69898bd)

therealak12 @therealak12 69898bd #37668 merge main@712b736

Use the `do_ci.sh` script for refreshing the compilation database

Commit Message: use do_ci.sh for refreshing the compilation db

Additional Description:
Details are explained in this Github comment.

When refreshing the compilation database, the proto_format.sh and gen_compilation_database.py scripts require the --config=clang and --config=libc++ flags. The do_ci.sh script provides a refresh_compdb subcommand that automatically includes these flags.

This PR modifies the .vscode/tasks.json file to use ci/do_ci.sh refresh_compdb instead of refresh_compdb.sh to refresh the compilation database used by VSCode.

Risk Level: Low

Environment

Request variables

Key Value
ref b7a1b89
sha 69898bd
pr 37668
base-sha 712b736
actor therealak12 @therealak12
message Use the do_ci.sh script for refreshing the compilation database...
started 1734893917.633588
target-branch main
trusted false
Build image

Container image/s (as used in this CI run)

Key Value
default envoyproxy/envoy-build-ubuntu:d2be0c198feda0c607fa33209da01bf737ef373f
mobile envoyproxy/envoy-build-ubuntu:mobile-d2be0c198feda0c607fa33209da01bf737ef373f
Version

Envoy version (as used in this CI run)

Key Value
major 1
minor 33
patch 0
dev true