-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentelemetry tracer: implement TraceIDRatioBased and ParentBased samplers #37787
base: main
Are you sure you want to change the base?
Conversation
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
e186869
to
b6bfb74
Compare
the warning is not relevant this is the important line Code coverage for source/extensions/tracers/opentelemetry/samplers/trace_id_ratio_based is lower than limit of 96.6 (84.8) /coverage |
Coverage for this Pull Request will be rendered here: https://storage.googleapis.com/envoy-pr/37787/coverage/index.html The coverage results are (re-)rendered each time the CI |
1573f58
to
07cb847
Compare
Thanks for your guidance, dear @phlax. Tests are passing now. |
Thanks for the contribution. Please read the https://github.com/envoyproxy/envoy/blob/main/CONTRIBUTING.md and https://github.com/envoyproxy/envoy/blob/main/EXTENSION_POLICY.md to get more infomation about adding new extensions to see if the new extensions meet the requirement or not. Thanks again! |
Signed-off-by: Ahmad Karimi <[email protected]>
07cb847
to
d70cd7e
Compare
Thanks for the links, @wbpcode! I’ve reviewed them and made the necessary adjustments to my PR. However, just to clarify, my PR doesn't add a new extension; rather, it implements two missing samplers for the OpenTelemetry tracer extension. Could you please let me know if that matches your expectations? |
If you get a chance, I'd appreciate any feedback or comments when you have time. No rush, I understand you're busy. |
Sorry for the delay. I skipped messages from community these two days. It's no doubt this add some new extensions. Although these extensions are not top level extensions but sub extensions for opentelmetry. But it doesn't change to much the characteristics. So, at least, we should ensure the current owners of opentelmetry @AlexanderEllis @yanavlasov are willing to maintain these new two extensions. |
/wait-any |
I would appreciate it if you took a look at this when you have a moment. |
Have you had a chance to review this PR? It's crucial for our tracing implementation. |
Commit Message: implement TraceIDRatioBased and ParentBased samplers
Additional Description:
A previous issue existed for adding opentelemetry samplers to Envoy so I didn't create a new one. The PR at hand implements two of these samplers.
The implementation and testing strategies are inspired by the OTEL's Go and CPP SDKs.
Risk Level: Low
Testing: The PR has unit and integration tests which I've run locally.
Docs Changes:
Release Notes:
Platform Specific Features: