http2: updates test coverage for Http2CodecImplTest.CheckHeaderValueValidation #37966
Conversation
Signed-off-by: Biren Roy <[email protected]>
Signed-off-by: Biren Roy <[email protected]>
|
/assign @adisuissa |
|
Looks like the |
|
Is this failure real? https://github.com/envoyproxy/envoy/actions/runs/12717776264/job/35454951834 |
Signed-off-by: Biren Roy <[email protected]>
Looks like UHV + oghttp2 fails for some reason. I'll leave the test exclusion in place for that combination. |
| TestRequestHeaderMapImpl request_headers; | ||
| HttpTestUtility::addDefaultHeaders(request_headers); | ||
| header_value[2] = static_cast<char>(i); | ||
|
|
||
| SCOPED_TRACE(absl::StrCat("header value: [", absl::CEscape(header_value), "]")); |
There was a problem hiding this comment.
Just checking that this addition is intentional?
There was a problem hiding this comment.
The only effect is to print the header value to logs iff a test expectation fails. I found this helpful when looking at the UHV + oghttp2 case. If you think it impedes readability, I can remove it.
There was a problem hiding this comment.
Nah, totally fine to have it. Wasn't sure if it was useful or just a one-off. Thanks for confirming!
The only case where codec behavior differs is
\0, so that case is still skipped.UHV + oghttp2 is also skipped, as otherwise the
compile-time-optionsbuild fails.Commit Message:
Additional Description:
Risk Level: none, test only
Testing: ran codec_impl_test locally
Docs Changes:
Release Notes:
Platform Specific Features: