Drop unused constants to make newer versions of clang happy #37970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On newer version of Clang those generate a warning and with the settings we use ultimately result in a compilation failure. We probably should either disable the warning or just adjust the test. Looking at the history of the test, it seems that these constants have never been used, so I prefer to just drop them. Signed-off-by: Mikhail Krinkin <[email protected]>
jmarantz
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
On newer version of Clang those generate a warning and with the settings we use ultimately result in a compilation failure.
We probably should either disable the warning or just adjust the test. Looking at the history of the test, it seems that these constants have never been used, so I prefer to just drop them.
Additional Description:
It's related to #37911, it appears that the compiler warning that causes this test fail to compile on clang 18 didn't exist in clang 14 that we are currently using.
Risk Level: Low
Testing: by running changed test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a