router: fix query parameter present_match support #38000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Agrawal <[email protected]>
agrawroh
force-pushed
the
qery_params_presence
branch
from
ede56ce to
6014488
Compare
|
@alyssawilk Could you please help review this small PR to fix query params |
alyssawilk
reviewed
Jan 15, 2025
Signed-off-by: Rohit Agrawal <[email protected]>
…resence Signed-off-by: Rohit Agrawal <[email protected]>
alyssawilk
approved these changes
Jan 16, 2025
There was a problem hiding this comment.
LGTM. @ggreenway given I'm still under the weather can you sanity check this LGTY?
wbpcode
approved these changes
Jan 20, 2025
|
@alyssawilk Is it okay to merge this? |
|
yeah sorry wanted a second maintainer look and looks like @wbpcode looked |
bazmurphy
pushed a commit
to bazmurphy/envoy
that referenced
this pull request
Jan 29, 2025
## Description The query parameter matcher implementation did not properly implement `present_match` functionality. While the matcher code exists, it isn't properly initializing the matcher, causing `present_match` checks to always fail. This PR adds the missing functionality and also adds the test coverage to verify both `present_match: true` and `present_match: false` behaviors work as expected. **Fixes:** envoyproxy#37951 --- **Commit Message:** router: fix query parameter present_match support **Additional Description:** Adds the missing support for `present_match` while matching query parameters. **Risk Level:** Low **Testing:** Added Unit Tests **Docs Changes:** N/A **Release Notes:** Added --------- Signed-off-by: Rohit Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query parameter matcher implementation did not properly implement
present_matchfunctionality. While the matcher code exists, it isn't properly initializing the matcher, causingpresent_matchchecks to always fail.This PR adds the missing functionality and also adds the test coverage to verify both
present_match: trueandpresent_match: falsebehaviors work as expected.Fixes: #37951
Commit Message: router: fix query parameter present_match support
Additional Description: Adds the missing support for
present_matchwhile matching query parameters.Risk Level: Low
Testing: Added Unit Tests
Docs Changes: N/A
Release Notes: Added