Add propagate_unsampled field to trace config #38223
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
wtzhang23
changed the title
wtzhang23
force-pushed
the
transparent-tracing
branch
from
84872bb to
3bd518d
Compare
Signed-off-by: William <[email protected]>
wtzhang23
force-pushed
the
transparent-tracing
branch
from
3bd518d to
40a3361
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: add propagate_unsampled field to trace config
Additional Description:
This PR prevents Span implementations from modifying the existing trace context by not constructing them if propagate_unsampled=true
Risk Level: Medium
Testing: Unit tests
Docs Changes: inline in proto
Release Notes: Added
Platform Specific Features: N/A
Fixes #38222