Skip to content

dfp: add support for DFP honoring dynamic_host filter state when configured #39605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

agrawroh
Copy link
Contributor

Description

The HTTP Dynamic Forward Proxy filter doesn't honor the envoy.upstream.dynamic_host filter state value that's set in the stream info, while both the SNI Dynamic Forward Proxy and UDP Dynamic Forward Proxy filters properly check for and use this value.

This inconsistency means host overriding via filter state works for SNI/UDP proxies but not for HTTP proxies. IMO the behavior is a bit confusing when trying to use the same filter state mechanism across different proxy types.

Changes

This PR adds a new flag called allow_dynamic_host_from_filter_state which when enabled allows HTTP DFP filter to use the filter state values for host and port lookups.

Fixes: #39579


Commit Message: dfp: add support for DFP honoring dynamic_host filter state when configured
Additional Description: Add support for DFP to honor dynamic_host and dynamic_port filter state values when configured.
Risk Level: Low
Testing: Added Unit & Integration Tests
Docs Changes: Added
Release Notes: Added

Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #39605 was opened by agrawroh.

see: more, trace.

Copy link

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @adisuissa
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #39605 was opened by agrawroh.

see: more, trace.

@agrawroh agrawroh force-pushed the http-dfp-dyn-hst branch 4 times, most recently from d24012f to 01dee7c Compare May 22, 2025 23:05
@agrawroh agrawroh marked this pull request as ready for review May 22, 2025 23:22
@agrawroh agrawroh force-pushed the http-dfp-dyn-hst branch from 01dee7c to a62940a Compare May 23, 2025 03:33
@agrawroh agrawroh marked this pull request as draft May 23, 2025 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants