Skip to content

Avoid trace span buffer becoming too large #39609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Patrick0308
Copy link
Contributor

@Patrick0308 Patrick0308 commented May 23, 2025

Commit Message: Avoid trace span buffer becoming too large
Additional Description:
See istio/istio#55439 (comment) , the sidecar space-inuse flame graph shows sometimes span serialize message grow too large, maybe it's caused by sending span to remote server is too slow. We should avoid this memory growing.
image

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:

@Patrick0308 Patrick0308 requested a review from yanavlasov as a code owner May 23, 2025 09:43
@Patrick0308 Patrick0308 force-pushed the fix-opentelemetry-buffer-too-big branch from adfbd33 to d4e3790 Compare May 23, 2025 09:54
Signed-off-by: 白泽 <[email protected]>
@Patrick0308
Copy link
Contributor Author

Patrick0308 commented May 25, 2025

@yanavlasov @wbpcode PTAL

Signed-off-by: 白泽 <[email protected]>
Copy link
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a better test for this.

Also, I would have this be configured in config also, and have some sane default.

/wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants