http3: Change Envoy's HTTP/3 implementation to validate pseudo headers #39615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be disabled by setting ``envoy.restart_features.do_not_validate_http3_pseudo_headers`` to false. Signed-off-by: Ryan Hamilton <[email protected]>
|
/assign @yanavlasov |
yanavlasov
approved these changes
May 23, 2025
|
/retest |
yanavlasov
requested changes
May 23, 2025
| @@ -967,7 +967,8 @@ TEST_P(QuicHttpIntegrationTest, DeferredLoggingWithQuicReset) { | |||
| EXPECT_EQ(/* request headers */ metrics.at(19), metrics.at(20)); | |||
| } | |||
|
|
|||
| TEST_P(QuicHttpIntegrationTest, DeferredLoggingWithEnvoyReset) { | |||
| // TODO(RyanTheOptimist): Re-enable after figuring out how to cause this reset. | |||
| // TEST_P(QuicHttpIntegrationTest, DeferredLoggingWithEnvoyReset) { | |||
There was a problem hiding this comment.
Suggested change
| // TEST_P(QuicHttpIntegrationTest, DeferredLoggingWithEnvoyReset) { | |
| // TEST_P(QuicHttpIntegrationTest, DISABLED_DeferredLoggingWithEnvoyReset) { |
There was a problem hiding this comment.
Wow, how did I mess that up? Fixed.
Signed-off-by: Ryan Hamilton <[email protected]>
yanavlasov
previously approved these changes
May 23, 2025
Signed-off-by: Ryan Hamilton <[email protected]>
Signed-off-by: Ryan Hamilton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be disabled by setting
envoy.restart_features.do_not_validate_http3_pseudo_headersto false.