use first value of override_auto_sni_header #39618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
agrawroh
reviewed
May 24, 2025
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
|
/assign-from @envoyproxy/senior-maintainers This is core code change and require another approval from senior maintainer |
|
@envoyproxy/senior-maintainers assignee is @RyanTheOptimist |
RyanTheOptimist
previously approved these changes
May 27, 2025
SGTM. |
Signed-off-by: wangbaiping(wbpcode) <[email protected]>
done. |
RyanTheOptimist
approved these changes
May 27, 2025
RyanTheOptimist
approved these changes
May 27, 2025
|
/retest |
1 similar comment
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message: use first value of override_auto_sni_header
Additional Description:
Tht getAll* will concat multiple header values with
,and make the output value actually isn't legal fqdn. This PR changed it to use the first header value ofoverride_auto_sni_headerjust like theauto_host_rewrite_headerdid.Risk Level: low.
Testing: n/a.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.