Skip to content

Commit

Permalink
e2e: fix trusted cidr e2e tests for ipv6 (#5067)
Browse files Browse the repository at this point in the history
fix trusted cidr e2e tests for ipv6

Signed-off-by: Rudrakh Panigrahi <[email protected]>
  • Loading branch information
rudrakhp authored Jan 15, 2025
1 parent 3e35b12 commit 18207c1
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 3 additions & 2 deletions test/e2e/testdata/authorization-client-ip-trusted-cidrs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ spec:
clientIPDetection:
xForwardedFor:
trustedCIDRs:
- "172.16.0.0/12"
- "10.0.1.0/24"
- "172.0.0.0/8"
- "10.0.0.0/8"
- "::/0" # trust all IPv6 addresses for E2E

Check warning on line 50 in test/e2e/testdata/authorization-client-ip-trusted-cidrs.yaml

View workflow job for this annotation

GitHub Actions / lint

50:16 [comments] too few spaces before comment

Check warning on line 50 in test/e2e/testdata/authorization-client-ip-trusted-cidrs.yaml

View workflow job for this annotation

GitHub Actions / lint

50:16 [comments] too few spaces before comment
targetRefs:
- group: gateway.networking.k8s.io
kind: Gateway
Expand Down
3 changes: 1 addition & 2 deletions test/e2e/tests/authorization_client_ip.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@ import (

func init() {
ConformanceTests = append(ConformanceTests, AuthorizationClientIPTest)
// Uncomment once https://github.com/envoyproxy/gateway/issues/5063 is fixed
// ConformanceTests = append(ConformanceTests, AuthorizationClientIPTrustedCidrsTest)
ConformanceTests = append(ConformanceTests, AuthorizationClientIPTrustedCidrsTest)
}

var AuthorizationClientIPTest = suite.ConformanceTest{
Expand Down

0 comments on commit 18207c1

Please sign in to comment.