Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: support disable ALPN in CTP #4515

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

guydc
Copy link
Contributor

@guydc guydc commented Oct 24, 2024

What type of PR is this?

What this PR does / why we need it:

  • Makes it possible to opt-out of ALPN in CTP by specifying an empty (non-nil) list of ALPN protos.
  • Improves ALPN docs in tls_types.go relating to default, downstream/upstream behavior, etc.

Which issue(s) this PR fixes:

Fixes #4462

Release Notes: Yes

@guydc guydc requested a review from a team as a code owner October 24, 2024 12:06
@guydc guydc added the release-note Indicates a required release note label Oct 24, 2024
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@44408dd). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4515   +/-   ##
=======================================
  Coverage        ?   65.55%           
=======================================
  Files           ?      211           
  Lines           ?    31945           
  Branches        ?        0           
=======================================
  Hits            ?    20943           
  Misses          ?     9757           
  Partials        ?     1245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@arkodg arkodg requested review from a team November 7, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note Indicates a required release note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow ALPN opt-out
2 participants