Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: continue using and drain serving endpointslices during termination #4946

Merged
merged 2 commits into from
Jan 17, 2025

Merge branch 'main' into main

d5d1be9
Select commit
Loading
Failed to load commit list.
Merged

feat: continue using and drain serving endpointslices during termination #4946

Merge branch 'main' into main
d5d1be9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

66.78% (target 60.00%)

View this Pull Request on Codecov

66.78% (target 60.00%)

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 66.78%. Comparing base (c499b41) to head (d5d1be9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/ir/xds.go 0.00% 4 Missing ⚠️
internal/gatewayapi/route.go 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4946      +/-   ##
==========================================
- Coverage   66.84%   66.78%   -0.07%     
==========================================
  Files         211      210       -1     
  Lines       32920    32953      +33     
==========================================
+ Hits        22007    22008       +1     
- Misses       9586     9607      +21     
- Partials     1327     1338      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.