Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump osv scanner to 1.9.2 #4956

Merged
merged 7 commits into from
Dec 31, 2024
Merged

Conversation

zhaohuabing
Copy link
Member

@zhaohuabing zhaohuabing commented Dec 20, 2024

@zhaohuabing zhaohuabing requested a review from a team as a code owner December 20, 2024 06:29
@zhaohuabing zhaohuabing marked this pull request as draft December 20, 2024 06:30
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.69%. Comparing base (c6d5a54) to head (47d9574).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4956      +/-   ##
==========================================
- Coverage   66.76%   66.69%   -0.08%     
==========================================
  Files         209      209              
  Lines       32052    32052              
==========================================
- Hits        21399    21376      -23     
- Misses       9380     9394      +14     
- Partials     1273     1282       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing force-pushed the bump-osv-scanner branch 8 times, most recently from adb07b7 to 798859e Compare December 20, 2024 07:33
@github-advanced-security

This comment was marked as outdated.

@zhaohuabing zhaohuabing force-pushed the bump-osv-scanner branch 2 times, most recently from d2ae91a to 01fa885 Compare December 20, 2024 07:43
@zhaohuabing zhaohuabing marked this pull request as ready for review December 20, 2024 07:46
zirain
zirain previously approved these changes Dec 20, 2024
@shahar-h
Copy link
Contributor

@zhaohuabing you can uncomment this now.

zirain
zirain previously approved these changes Dec 21, 2024
Signed-off-by: Huabing Zhao <[email protected]>
zirain
zirain previously approved these changes Dec 24, 2024
@shahar-h
Copy link
Contributor

@zhaohuabing license scan fails because github.com/docker/[email protected]+incompatible license is not identified. I opened an issue in deps.dev. For now you can add license override in license-scan-config.toml:

[[PackageOverrides]]
name = "github.com/docker/cli"
version = "v27.4.0+incompatible"
ecosystem = "Go"
license.override = ["Apache-2.0"]
reason = "Unidentified license, remove once https://github.com/google/deps.dev/issues/146 is resolved"

@zirain
Copy link
Member

zirain commented Dec 24, 2024

+-------------------+-----------+-------------------------------------------------------------------+-----------------------------------+--------+
| LICENSE VIOLATION | ECOSYSTEM | PACKAGE                                                           | VERSION                           | SOURCE |
+-------------------+-----------+-------------------------------------------------------------------+-----------------------------------+--------+
| UNKNOWN           | Go        | github.com/docker/cli                                             | 27.4.0+incompatible               | go.mod |
| UNKNOWN           | Go        | github.com/docker/docker                                          | 27.4.1+incompatible               | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel                                          | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/exporters/prometheus                     | 0.55.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/exporters/stdout/stdoutmetric            | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/metric                                   | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/sdk                                      | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/sdk/metric                               | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | go.opentelemetry.io/otel/trace                                    | 1.33.0                            | go.mod |
| UNKNOWN           | Go        | google.golang.org/genproto/googleapis/api                         | 0.0.0-202[41](https://github.com/envoyproxy/gateway/actions/runs/12478808774/job/34826939541#step:4:42)209162323-e6fa225c2576 | go.mod |
| UNKNOWN           | Go        | google.golang.org/genproto/googleapis/rpc                         | 0.0.0-20241209162323-e6fa225c2576 | go.mod |
| UNKNOWN           | Go        | helm.sh/helm/v3                                                   | 3.16.4                            | go.mod |
+-------------------+-----------+-------------------------------------------------------------------+-----------------------------------+--------+

@zirain
Copy link
Member

zirain commented Dec 24, 2024

we can not ignore them all one by one.

@shahar-h
Copy link
Contributor

we can not ignore them all one by one.

Wow! I'll open an issue in deps.dev regarding all of these go packages old data and update here.
For now we can add continue-on-error: true to avoid failing on license violations:

continue-on-error: true # TODO remove once all issues are resolved

Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from shahar-h December 31, 2024 02:39
@zirain zirain merged commit 57e6b52 into envoyproxy:main Dec 31, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GitHub Action] Call analysis doesn't work for go projects with go version > 1.22.8
3 participants