feat: implement response compression #5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaohuabing
force-pushed
the
compression
branch
from
4e010ee to
9c0ddb8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5001 +/- ##
==========================================
+ Coverage 66.70% 66.71% +0.01%
==========================================
Files 210 211 +1
Lines 32647 32811 +164
==========================================
+ Hits 21777 21891 +114
- Misses 9554 9591 +37
- Partials 1316 1329 +13 ☔ View full report in Codecov by Sentry. |
zhaohuabing
force-pushed
the
compression
branch
5 times, most recently
from
76681e4 to
0d5cc71
Compare
zhaohuabing
commented
Jan 6, 2025
| @@ -32,8 +32,8 @@ func init() { | |||
| // Copied from the conformance suite because it's needed in casePreservingRoundTrip | |||
| var startLineRegex = regexp.MustCompile(`(?m)^`) | |||
|
|
|||
| func formatDump(data []byte, prefix string) string { | |||
| data = startLineRegex.ReplaceAllLiteral(data, []byte(prefix)) | |||
| func formatDump(data []byte) string { | |||
There was a problem hiding this comment.
To fix lint error:
test/e2e/tests/preservecase.go:35:30: `formatDump` - `prefix` always receives `"< "` (unparam)
870e368 to
1f85138
Compare
zhaohuabing
changed the title
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
compression
branch
from
f676e62 to
093939d
Compare
Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
compression
branch
from
093939d to
7f697d9
Compare
arkodg
reviewed
Jan 10, 2025
arkodg
reviewed
Jan 10, 2025
arkodg
reviewed
Jan 10, 2025
internal/gatewayapi/testdata/backendtrafficpolicy-compression.in.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
This reverts commit 969d0db. Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing
force-pushed
the
compression
branch
from
fda0b04 to
20bd82a
Compare
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
arkodg
approved these changes
Jan 13, 2025
zirain
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for response compression in the
BackendTrafficPolicy.Currently, brotli and gzip are supported.
Implements #2451
Release Notes: Yes