-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update grafana dashboard and exported metrics doc for watchable_panics_recovered_total #5036
base: main
Are you sure you want to change the base?
update grafana dashboard and exported metrics doc for watchable_panics_recovered_total #5036
Conversation
…red_total Signed-off-by: DeeBi9 <[email protected]>
Signed-off-by: DeeBi9 <[email protected]>
…anel for recovered panics Signed-off-by: DeeBi9 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5036 +/- ##
==========================================
+ Coverage 66.75% 66.81% +0.05%
==========================================
Files 209 209
Lines 32409 32409
==========================================
+ Hits 21636 21655 +19
+ Misses 9468 9455 -13
+ Partials 1305 1299 -6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code overall looks good!
Can you run make -k gen-check
to make the gencheck pass? Also can you add a screenshot image of this metric in grafana in the PR description ?
This is the screenshot for the metric I have verified that the other metrics (like I have checked the prometheus directly for the metrics Thanks |
What type of PR is this?
Update Grafana dashboard and exported metrics doc for watchable_panics_recovered_total
What this PR does / why we need it:
This PR updates the Grafana Dashboard to include the newly introduced metric watchable_panics_recovered_total, which tracks the total number of panics recovered in the Envoy Gateway system. It also updates the Exported Metrics Documentation to reflect the new metric and provide users with guidance on its use.
Which issue(s) this PR fixes:
#4728