Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. #5085

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

zhaohuabing
Copy link
Member

docs for: #5011

@zhaohuabing zhaohuabing requested a review from a team as a code owner January 17, 2025 08:23
@zhaohuabing zhaohuabing requested review from a team and removed request for a team January 17, 2025 08:34
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.88%. Comparing base (549fdde) to head (11e4b80).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5085      +/-   ##
==========================================
+ Coverage   66.86%   66.88%   +0.02%     
==========================================
  Files         210      210              
  Lines       32979    32979              
==========================================
+ Hits        22052    22059       +7     
+ Misses       9588     9584       -4     
+ Partials     1339     1336       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zhaohuabing zhaohuabing changed the title Docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. docs: how to specify a self-signed ca for the remote jwks host in the SP JWT settings. Jan 17, 2025
@arkodg arkodg added this to the v1.3.0 milestone Jan 21, 2025
@arkodg
Copy link
Contributor

arkodg commented Jan 24, 2025

hey @zhaohuabing the files are empty here 😕

@zhaohuabing
Copy link
Member Author

hey @zhaohuabing the files are empty here 😕

Updated, I modified the docs in the wrong directory and the changes have been overwritten by the make gen-check. :-)

Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing zhaohuabing merged commit fdc7849 into envoyproxy:main Jan 27, 2025
28 checks passed
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Jan 27, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <[email protected]>

* fix gen

Signed-off-by: Huabing Zhao <[email protected]>

* update docs

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Jan 27, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <[email protected]>

* fix gen

Signed-off-by: Huabing Zhao <[email protected]>

* update docs

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
zhaohuabing added a commit to zhaohuabing/gateway that referenced this pull request Jan 27, 2025
… SP JWT settings. (envoyproxy#5085)

* docs for jwt self-signed ca

Signed-off-by: Huabing Zhao <[email protected]>

* fix gen

Signed-off-by: Huabing Zhao <[email protected]>

* update docs

Signed-off-by: Huabing Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants