fix lint

Signed-off-by: Alec Holmes <[email protected]>
envoyproxy · Jan 27, 2023 · 289ca0a · 289ca0a
1 parent 632c311
commit 289ca0a
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 15 deletions.
diff --git a/benchmarks/README.md b/benchmarks/README.md
@@ -3,7 +3,7 @@
 These benchmarks are designed to run off the integration test suite, and provide detailed profiling artifacts generated with pprof.
 
 ## Prerequisites
-- [Go 1.16+](https://golang.org/dl/)
+- [Go 1.17+](https://golang.org/dl/)
 - [Graphviz](https://graphviz.org/download/)
 - [pprof](https://github.com/google/pprof)
 - [Docker](https://www.docker.com/)

diff --git a/benchmarks/client/main.go b/benchmarks/client/main.go
@@ -6,8 +6,9 @@ import (
 	"runtime"
 	"time"
 
-	"github.com/envoyproxy/go-control-plane/benchmarks/client/xds"
 	"github.com/urfave/cli/v2"
+
+	"github.com/envoyproxy/go-control-plane/benchmarks/client/xds"
 )
 
 func main() {

diff --git a/benchmarks/client/xds/xds.go b/benchmarks/client/xds/xds.go
@@ -4,6 +4,7 @@ import (
 	"time"
 
 	"google.golang.org/grpc"
+	"google.golang.org/grpc/credentials/insecure"
 )
 
 // Sess holds a grpc connection as well as config options to use during the simulation
@@ -19,7 +20,7 @@ func NewSession(url string, opts ...Option) (*Sess, error) {
 		o(&options)
 	}
 
-	conn, err := grpc.Dial(url, grpc.WithBlock(), grpc.WithInsecure())
+	conn, err := grpc.Dial(url, grpc.WithBlock(), grpc.WithTransportCredentials(insecure.NewCredentials()))
 	if err != nil {
 		return nil, err
 	}
@@ -30,16 +31,16 @@ func NewSession(url string, opts ...Option) (*Sess, error) {
 	}, nil
 }
 
-// Simulate will start an xDS stream which provides simulatest clients communicating with an xDS server
+// Simulate will start an xDS stream which provides simulated clients communicating with an xDS server
 func (s *Sess) Simulate(target time.Duration) error {
 	// Create a loop that will continually do work until the elapsed time as passed
 	for timeout := time.After(target); ; {
 		select {
 		case <-timeout:
 			return nil
 		default:
+			// TODO(alec): implement me
 			// Do some work
-
 		}
 	}
 }
diff --git a/pkg/test/main/main.go b/pkg/test/main/main.go
@@ -36,11 +36,11 @@ import (
 )
 
 const (
-	PPROF_CPU int = iota
-	PPROF_HEAP
-	PPROF_MUTEX
-	PPROF_BLOCK
-	PPROF_GOROUTINE
+	PprofCPU int = iota
+	PprofHEAP
+	PprofMUTEX
+	PprofBLOCK
+	PprofGOROUTINE
 )
 
 var (
@@ -171,15 +171,15 @@ func main() {
 
 	if debug {
 		switch pprofMode {
-		case PPROF_CPU:
+		case PprofCPU:
 			defer profile.Start(profile.CPUProfile, profile.ProfilePath("."), profile.NoShutdownHook).Stop()
-		case PPROF_HEAP:
+		case PprofHEAP:
 			defer profile.Start(profile.MemProfile, profile.ProfilePath(".")).Stop()
-		case PPROF_MUTEX:
+		case PprofMUTEX:
 			defer profile.Start(profile.MutexProfile, profile.ProfilePath(".")).Stop()
-		case PPROF_BLOCK:
+		case PprofBLOCK:
 			defer profile.Start(profile.BlockProfile, profile.ProfilePath(".")).Stop()
-		case PPROF_GOROUTINE:
+		case PprofGOROUTINE:
 			defer profile.Start(profile.GoroutineProfile, profile.ProfilePath(".")).Stop()
 		}
 	}