fixed integration test for ads #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alec Holmes <[email protected]>
snowp
requested changes
May 27, 2021
Comment on lines
-38
to
-52
| name: xds_cluster | ||
| layered_runtime: | ||
| layers: | ||
| - name: runtime-0 | ||
| rtds_layer: | ||
| rtds_config: | ||
| resource_api_version: V3 | ||
| ads: {} | ||
| name: runtime-0 | ||
| - name: runtime-1 | ||
| rtds_layer: | ||
| rtds_config: | ||
| resource_api_version: V3 | ||
| ads: {} | ||
| name: runtime-1 |
There was a problem hiding this comment.
Can you file an issue to look into this? I don't see why this shouldn't work
There was a problem hiding this comment.
@snowp sure thing, do you want an issue in Envoy as well? Or just in the control-plane code
There was a problem hiding this comment.
Let's keep it here for now until we can figure out what's wrong. Would be great if you could include the logs you got earlier
There was a problem hiding this comment.
Okay cool I'll file an issue
Signed-off-by: Alec Holmes <[email protected]>
alecholmez
added a commit
that referenced
this pull request
Jun 21, 2021
fixed integration tests for ads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alec Holmes [email protected]