Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix to requested resource does not exist handling #373

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

staticfinalzero
Copy link

Bug fix to requested resource does not exist handling. We need to keep watch active for when resource is finally created so we can notify client.

This is to match the xDS spec for how to handle the "resource does not exist" scenario.

Open issue: #219

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (eaca1a4) to head (272d28f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #373      +/-   ##
============================================
- Coverage     86.16%   86.15%   -0.02%     
  Complexity      361      361              
============================================
  Files            42       42              
  Lines          1178     1177       -1     
  Branches         97       97              
============================================
- Hits           1015     1014       -1     
  Misses          116      116              
  Partials         47       47              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rulex123
Copy link
Collaborator

@staticfinalzero looks like you haven't signed off your commit and that causes CI to be red. Any chance you can fix?

we need to keep watch active for when resource is finally created so we can notify client.

envoyproxy#219
Signed-off-by: staticfinalzero <[email protected]>
@staticfinalzero
Copy link
Author

Sorry about that, I've amended the commit and signed off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants