Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dogstatsd_sink): switch from pure map to list of key/value pairs #627

Merged
merged 1 commit into from
Jun 20, 2024
Merged

fix(dogstatsd_sink): switch from pure map to list of key/value pairs #627

merged 1 commit into from
Jun 20, 2024
+43 −22

Commits on Jun 20, 2024

  1. fix(dogstatsd_sink): switch from pure map to list of key/value pairs 

    The test for Two mogrifiers: First match has flaky results because the
underlying iteration order from the map is not guaranteed. Sometimes
matching first and sometimes matching second mogrifier.

Having a consistent mogrifier order is required for some types of
priority based manipulation, and that is how the keys are defined in the
environment, so changing the overall implementation to a slice to
maintain ordered iteration is the best option. And can be done by only
changing the internal private types.

Signed-off-by: Josh Jaques <[email protected]>
    @JDeuce
    JDeuce committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    7a832a2 View commit details
    Browse the repository at this point in the history