Skip to content

Fix extension checker error message #2871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

Fix extension checker error message #2871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
458132b
Update error message for unknown extension category
sfc-gh-igadot Sep 26, 2025
05c73e1
Update test
sfc-gh-igadot Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion envoy.code.check/envoy/code/check/abstract/extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ async def _check_metadata_categories(
"and category is set", )
return tuple(
(f"Unknown extension category for {extension}: {cat}. "
"Please add it to tools/extensions/extensions_check.py")
"Please add it to {EXTENSIONS_SCHEMA}")
for cat
in categories
if cat not in self.extension_categories)
Expand Down
2 changes: 1 addition & 1 deletion envoy.code.check/tests/test_abstract_extensions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1066,7 +1066,7 @@ async def test_extensions__check_metadata_categories(
if wrong_cats:
expected = tuple(
f"Unknown extension category for EXTENSION: {cat}. "
"Please add it to tools/extensions/extensions_check.py"
"Please add it to tools/extensions/extensions_schema.yaml"
for cat
in wrong_cats)
else:
Expand Down