Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for use of width/height. #662

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ari
Copy link

@ari ari commented Jun 16, 2021

  • This is a documentation change.

Description

Fixes old docs which are just wrong.

@ari ari requested a review from envygeeks as a code owner June 16, 2021 13:40
Copy link

@xaviershay xaviershay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

{{ assets["images.jpg"].width }} => 62
{{ assets["images.jpg"].height }} => 62
{{ assets["images.jpg"].dimensionns.width }} => 62
{{ assets["images.jpg"].dimensionns.height }} => 62

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ assets["images.jpg"].dimensionns.height }} => 62
{{ assets["images.jpg"].dimensions.height }} => 62

@@ -277,8 +277,8 @@ names of the original files, e.g., use `*.scss` instead of `*.css`.

```liquid
{{ assets["bundle.css"].content_type }} => "text/css"
{{ assets["images.jpg"].width }} => 62
{{ assets["images.jpg"].height }} => 62
{{ assets["images.jpg"].dimensionns.width }} => 62

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{{ assets["images.jpg"].dimensionns.width }} => 62
{{ assets["images.jpg"].dimensions.width }} => 62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants