-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CircleCI Python several versions for future proofing #223
Conversation
Maybe try "-std=legacy" in Fortran compile? |
That's certainly an easier flag. Though for some reason it's not being passed when |
The problem is that the answer testing works by compiling a version with the current gold-standard (which does not have this flag) and then compiling a version with this PR changes. The PR changes are clearly working because the test-compile-options test passes, but the first step of the test-suite (compilation of the current gold-standard) is the thing that is failing. There is no way to fix that in a PR except by updating the gold-standard. I think that is probably what we need to do, go from gold-standard-15 to gold-standard-16. Unfortunately, this takes a few steps which are outlined here: enzo-project/enzo-e#307 |
I did not realize that the gold standard version was also compiled. I'll create a new issue for tracking the gold standard update. |
I've pushed a lightweight tag as part of this PR that should switch the gold standard to building with |
Thanks Claire! Now it looks like it is failing due to a pynose problem. I'm guessing that you may need to bump dependencies-v3 to dependencies-v4 in config.yml to clear the dependencies cache, since you bumped the CircleCI image. |
Tried Python 3.10.13, but nose might still not work (xlcnd/isbnlib#95) despite the issues of not(?) having python3 in the circleci image? |
Path forward: return to the 3.11.5 image and migrate from nose to pytest. Nose hasn't been updated since 2015 anyway. Added as issue #229 |
Tests passed but there are unyt errors in the reference tests |
12 of the reference tests fail due to a change with unyt v3. This is fixed by a PR on yt: yt-project/yt#4764 There is also an issue that, when comparing the new version of Enzo to the standard, the standard's answers don't seem to be saved. |
I have figured out the nuances of CircleCI. For future reference:
To maintainers: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- thanks Claire for persevering though all of that!
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I'm approving and merging.
Addresses #222