fix: use better parameter name (#158)

enzymefinance · Sep 26, 2023 · 5dec4c1 · 5dec4c1
1 parent 4dfd558
commit 5dec4c1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/.changeset/strong-pugs-run.md b/.changeset/strong-pugs-run.md
@@ -0,0 +1,5 @@
+---
+"@enzymefinance/sdk": patch
+---
+
+Use better parameter name
diff --git a/packages/sdk/src/internal/Extensions/IntegrationAdapters/CurveExchange.ts b/packages/sdk/src/internal/Extensions/IntegrationAdapters/CurveExchange.ts
@@ -22,7 +22,7 @@ const takeOrderEncoding = [
     type: "uint256",
   },
   {
-    name: "minIncomingAsset",
+    name: "incomingAsset",
     type: "address",
   },
   {
@@ -35,7 +35,7 @@ export type TakeOrderArgs = {
   pool: Address;
   outgoingAsset: Address;
   outgoingAssetAmount: bigint;
-  minIncomingAsset: Address;
+  incomingAsset: Address;
   minIncomingAssetAmount: bigint;
 };
 
@@ -44,13 +44,13 @@ export function takeOrderEncode(args: TakeOrderArgs): Hex {
     args.pool,
     args.outgoingAsset,
     args.outgoingAssetAmount,
-    args.minIncomingAsset,
+    args.incomingAsset,
     args.minIncomingAssetAmount,
   ]);
 }
 
 export function takeOrderDecode(encoded: Hex): TakeOrderArgs {
-  const [pool, outgoingAsset, outgoingAssetAmount, minIncomingAsset, minIncomingAssetAmount] = decodeAbiParameters(
+  const [pool, outgoingAsset, outgoingAssetAmount, incomingAsset, minIncomingAssetAmount] = decodeAbiParameters(
     takeOrderEncoding,
     encoded,
   );
@@ -59,7 +59,7 @@ export function takeOrderDecode(encoded: Hex): TakeOrderArgs {
     pool,
     outgoingAsset,
     outgoingAssetAmount,
-    minIncomingAsset,
+    incomingAsset,
     minIncomingAssetAmount,
   };
 }