Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Aave v3 asset type #598

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: fix Aave v3 asset type #598

merged 3 commits into from
Dec 12, 2024

Conversation

iherger
Copy link
Member

@iherger iherger commented Dec 11, 2024

PR-Codex overview

This PR updates asset definitions in the packages/environment/src/assets/base.ts file to introduce a new asset type for Aave v3. It modifies existing assets to reflect this change and adds underlying addresses for them.

Detailed summary

  • Changed asset type from AssetType.PRIMITIVE to AssetType.AAVE_V3 for:
    • Aave Base WETH
    • Aave Base USDC
  • Added underlying addresses for both assets:
    • aBasWETH: "0x4200000000000000000000000000000000000006"
    • aBasUSDC: "0x833589fcd6edb6e08f4c7c32d4f71b54bda02913"

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: cf9a1c1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@enzymefinance/environment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Dec 11, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@enzymefinance/abis@598
pnpm add https://pkg.pr.new/@enzymefinance/api@598
pnpm add https://pkg.pr.new/@enzymefinance/environment@598
pnpm add https://pkg.pr.new/@enzymefinance/sdk@598

commit: cf9a1c1

@iherger iherger requested a review from KedziaPawel December 12, 2024 07:13
@iherger iherger merged commit 687790e into main Dec 12, 2024
11 checks passed
@iherger iherger deleted the fix/aave-v3-asset-type branch December 12, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant