Run TrustEVM Contract Tests in CI #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2023
Merged
Merged
Merged
Merged
Merged
kj4ezj
force-pushed
the
zach-contract-tests
branch
from
5a5fd4c
to
434080d
Compare
kj4ezj
force-pushed
the
zach-contract-tests
branch
from
434080d
to
b2cc85f
Compare
spoonincode
approved these changes
Feb 13, 2023
| run: .github/workflows/test-contract.sh | ||
|
|
||
| - name: Upload Test Metrics | ||
| if: matrix.DWITH_TEST_ACTIONS == 'on' || matrix.DWITH_TEST_ACTIONS == 'true' |
There was a problem hiding this comment.
what's the need to check for on or true here? It seems like it could never be a value not defined in the matrix (on or off)?
There was a problem hiding this comment.
I guess I don't understand the question.
There was a problem hiding this comment.
Why can't this line (and all the other similar ifs) just be if: matrix.DWITH_TEST_ACTIONS == 'on'?
There was a problem hiding this comment.
Ah! I understand, now. The purpose of the or statement is in case someone uses true and false instead of on or off, which are also valid inputs to boolean cmake flags.
There was a problem hiding this comment.
So is yes and 1 though, but you're testing against the matrix value which can only be
strategy:
matrix:
DWITH_TEST_ACTIONS: ['on', 'off']
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From TrustEVM issue 242, this pull request builds on pull request 293 to add steps to the TrustEVM contract CI pipeline to run the contract tests and export xUnit test metrics.
The tests do not pass for me and I was informed on 2023-01-12 they are not expected to pass.
This pull requests runs them, but does not fail the build if the tests fail. I do not like this pattern, but this was requested by the team to track progress towards getting all tests passing.
See Also
.gitignore.gitignore-Deosio_DIRcmakeFlag from Contract Tests