Replace tx_wrapper with eos-evm-miner for integration test. #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CICD will need to checkout eos-evm-miner repo, run install/build, and let test know root location of the eos-evm-miner so it can launch a miner when needed. Environment is set up in test rather than writing out a .env file to avoid overwriting an existing .env file in the miner root directory.
Remove step to install tx-wrapper.
eos-evm-miner currently relies on the eosio.evm account, so switch to using eosio.evm over evmevmevmevm. Update miner configuration via setting private key, account name, rpc endpoint, and port for the test configuration. Fix eos-evm-node and eos-evm-rpc and eos-evm-miner being spun up in process daemon so that their respective processes can be cleaned up correctly. Fixes orphaned test processes. Add missing eos-evm-node argument ship-core-account now that account name has changed.
Removing peripherals/tx_wrapper is tx-wrapper has been deprecated in favor of eos-evm-miner.
oschwaldp-oci
changed the title
heifner
approved these changes
Aug 10, 2023
arhag
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update CICD to bring in eos-evm-miner as a dependency and use it in an upgraded integration test that uses eos-evm-miner rather than TX-Wrapper.
CICD now checks out eos-evm-miner repo, runs install/build, and lets test know root location of the eos-evm-miner so it can launch a miner when needed. Environment is set up in test rather than writing out a .env file to avoid overwriting an existing .env file in the miner root directory.
Some process handling/cleanup done in
nodeos_eos_evm_test.pyto ensure processes spawned by the test script are cleaned up properly.Deprecation -- TX-Wrapper is deprecated and is being removed herein
Resolves: #19