Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.0] add estimate_gas test #250

Merged
merged 2 commits into from
Jul 5, 2024
Merged

[1.0] add estimate_gas test #250

merged 2 commits into from
Jul 5, 2024

Conversation

taokayan
Copy link
Contributor

@taokayan taokayan commented Jul 2, 2024

Resolves #237

@taokayan taokayan requested a review from elmato July 2, 2024 03:55
@taokayan taokayan linked an issue Jul 3, 2024 that may be closed by this pull request
Integration test: Test eth_estimateGas after we change to evmversion=1 and GasParameters is changed #237
Closed
@elmato elmato changed the title add estimate_gas test [1.0] add estimate_gas test Jul 4, 2024
elmato
elmato requested changes Jul 5, 2024
View reviewed changes
tests/nodeos_eos_evm_test.py Outdated
if hasattr(signed_trx, 'raw_transaction'):
return signed_trx.raw_transaction
else:
return get_raw_transaction(signed_trx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be?

return signed_trx.rawTransaction

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. thanks

@elmato elmato merged commit 5b6a62b into release/1.0 Jul 5, 2024
5 of 6 checks passed
@elmato elmato deleted the kayan_estimategas_test branch July 5, 2024 00:30
@elmato elmato restored the kayan_estimategas_test branch July 10, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elmato elmato elmato requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration test: Test eth_estimateGas after we change to evmversion=1 and GasParameters is changed
2 participants
@taokayan @elmato