-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CICD build to use Leap v5 #140
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest upgrading the build to ubuntu22 at the same time. on ubuntu20, libtester 5.0 is built with gcc10 where as eos-system-contracts CI will still use gcc9 as currently configured. This will one day cause grief (it's why libtester on ubuntu20 isn't tested any longer in leap repo), and regardless of grief is probably a ODR violation like this too.
Alternatively we could change the current ubuntu20 workflow to use gcc10 just like libtester. But it's more forward looking (and cleaner imo) to just upgrade to ubuntu22.
You will need to change at least
runs-on: ubuntu-20.04 |
file: 'leap-dev.*(x86_64|amd64).deb' |
artifact-name: leap-dev-ubuntu20-amd64 |
No problem, we can make those changes. Can we upgrade to v4 build actions as well? This would pull in changes from PR #109 |
Note:start |
Currently set to use Leap v3, need to update CICD to Leap v5. Fixes #139