Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal for a new command line tool “leap-util” #72

Merged
merged 7 commits into from
Sep 21, 2022

Conversation

vladtr
Copy link
Contributor

@vladtr vladtr commented Aug 28, 2022

Nodeos is getting cluttered with commands. These commands should be spun out into a separate utility leap-util per:

https://github.com/eosnetworkfoundation/mandel/issues/697

More to that, we already have tools such eosio-blocklog containing all-blocklog functionality that should be integrated into one leap-util tool for clarity and simplicity of use.

Having a single “entry point” to a maintenance tool hopefully will make it easier for users.

@stephenpdeos
Copy link
Member

From today's discussion

Proposal discussion questions:

  1. In order to use bash autocomplete, a patched or forked version of CLI11 needs to be used. We need to decide what will be a right approach.

Yes, we want to use bash autocomplete. For now, we will plan to fork a version of CLI11. Over time, there is a chance the customized aspects we're using may get merged into CLI11's main.

  1. Also for autocomplete, a config script for bash needs to be added to installation step for *.deb packages. Should we require bash-completion package as mandatory dependency for leap, or if its not installed on user system, just ignore/warn about it and autocomplete wont work

This should be an optional dependency in debian package.

  1. Since we would be using CLI11 already in 2 places and potentially other cli utils will use it in future, it should be probably shaped into library vs one header file.

This should just be one library used by things like cleos and leap-util

Next steps:

  1. What does the visual experience look like for leap-util for some examples of commands we know will be used?
  • Vlad to mock up examples of a few commonly used cleos commands to illustrate anticipated experience.
  1. What is the full scope that leap-util encompasses?

@vladtr
Copy link
Contributor Author

vladtr commented Sep 7, 2022

Addressing "Next Steps":

  1. Examples of help / help-all options:
    image

Autocomplete example (pressing after command/subcommand, entering first letter of subcommand and -- for params). This is animated gif but for some reason runs at 1/2 speed, apologies for it being slow:
2022-09-07 17-37-08

  1. eosio-blocklog draftly ported as "blocklog" subcommand (please see this branch: https://github.com/AntelopeIO/leap/tree/leap-util).

@vladtr vladtr marked this pull request as ready for review September 7, 2022 21:46
@vladtr vladtr merged commit 6b6f4a4 into main Sep 21, 2022
@vladtr vladtr deleted the leap-util-proposal branch September 21, 2022 21:20
@arhag arhag mentioned this pull request Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants