Merge pull request #132 from eosnetworkfoundation/kayan_is_replay_pro…

…tected fix is_replay_protected
eosnetworkfoundation · Mar 18, 2024 · df1c04b · df1c04b
2 parents 107438a + 2354941
commit df1c04b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/silkworm/silkrpc/common/util.cpp b/silkworm/silkrpc/common/util.cpp
@@ -146,7 +146,7 @@ bool check_tx_fee_less_cap(float cap, const intx::uint256& max_fee_per_gas, uint
 
 bool is_replay_protected(const silkworm::Transaction& txn) {
     if (txn.type != TransactionType::kLegacy) {
-        return false;
+        return true;
     }
     intx::uint256 v = txn.v();
     if (v != 27 && v != 28 && v != 0 && v != 1) {

diff --git a/silkworm/silkrpc/common/util_test.cpp b/silkworm/silkrpc/common/util_test.cpp
@@ -132,7 +132,7 @@ TEST_CASE("check_tx_fee_less_cap returns false", "[silkrpc][common][util]") {
     CHECK(check == true);
 }
 
-TEST_CASE("is_replay_protected(tx legacy) returns true", "[silkrpc][common][util]") {
+TEST_CASE("is_replay_protected(tx non-legacy) returns true", "[silkrpc][common][util]") {
     const Transaction txn{
         {.type = TransactionType::kAccessList,
          .nonce = 0,
@@ -147,7 +147,7 @@ TEST_CASE("is_replay_protected(tx legacy) returns true", "[silkrpc][common][util
     };
 
     auto check = is_replay_protected(txn);
-    CHECK(check == false);
+    CHECK(check == true);
 }
 
 TEST_CASE("is_replay_protected returns true", "[silkrpc][common][util]") {