Consensus parameters storage #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elmato
requested changes
Feb 6, 2024
|
Updated to move the index to body. TODO: change the serialization method |
elmato
reviewed
Feb 28, 2024
| friend bool operator==(const BlockBody&, const BlockBody&); | ||
| }; | ||
|
|
||
| struct Block : public BlockBody { | ||
| BlockHeader header; | ||
|
|
||
| bool irreversible{false}; | ||
| std::optional<eosevm::ConsensusParameters> consensus_parameters_cache; |
There was a problem hiding this comment.
Do we need to have this cache here?
I thought it will be local to the function that prepares the execution of the block
There was a problem hiding this comment.
This is because we are currently only passing block around: from block_conversion_plugin to blockchain_plugin, from blockchain_plugin to the executor
It will be safer to copy and pass this piece of information with block. otherwise we will have to let executor read the new parameters from somewhere, and that will start to encounter thread safety issues.
This approach might not be ideal, Feel free to suggest other approaches.
elmato
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1 Add a way to store general consensus parameters, indexed by active block number.
2 currently it holds 5 gas fee parameters and the gas price
3 may subject to changes
Should be reviewed and merged together with other related changes in node.
Resolve #121