-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemente eos-evm gas-fee (G_codedeposit and G_txnewaccount) #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, but one question: where should we put the gas_parameters struct?
I have a similar structure in silkworm as well, we should unify them if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine. remember to test the trace result later.
evm_version = _version.has_value() ? *_version : 0; | ||
} else { | ||
evm_version = eosevm::nonce_to_version(header.nonce); | ||
if(protocol_rule_set == protocol::RuleSetType::kTrust) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to simply panic if anywhere calling this function while not using kTrust?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We wanted to preserve the old behavior in order to pass the original tests
|
||
} | ||
|
||
evmone::gas_parameters Execution::get_gas_params(const Block& block) const{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will need tx as argument. and this is the reason why i want to put a cache in block so the config can come for free in some cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we have the tx passed as argument in the forward function. I will do that in the other PR
No description provided.