Add missing functionality for the gas-fee algorithm #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarkinwho
requested changes
Mar 14, 2024
yarkinwho
reviewed
Mar 19, 2024
| @@ -259,7 +257,7 @@ evmc::Result EVM::call(const evmc_message& message) noexcept { | |||
| } else { | |||
|
|
|||
| evmc_message revisted_message{message}; | |||
| if(eos_evm_version_ > 0 && revisted_message.depth == 0 && recipient_is_dead) { | |||
| if(eos_evm_version_ > 0 && revisted_message.depth == 0 && !is_zero(evmc::bytes32{revisted_message.value}) && !recipient_exists) { | |||
There was a problem hiding this comment.
It seems will cause a functionality change if recipient is precompiled or reserved address?
What's the reason behind this change?
There was a problem hiding this comment.
We wanted to be consistent with what the CALL instruction is doing when trying to check if the account exists.
The instruction implementation its just calling the host function account_exists on the destination address, so we are doing the same when processing the call message coming from a transaction.
yarkinwho
approved these changes
Mar 19, 2024
…ber/eth_getBlockByHash api calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.