Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow recover regular evm addresses from s if r is 0 #46

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Allow recover regular evm addresses from s if r is 0 #46

merged 2 commits into from
Aug 14, 2023

Conversation

yarkinwho
Copy link
Contributor

@yarkinwho yarkinwho changed the base branch from elmato/new-silkworm-dev to master July 28, 2023 00:21
@yarkinwho yarkinwho requested a review from elmato July 28, 2023 00:21
arhag
arhag previously approved these changes Aug 8, 2023
View reviewed changes
@elmato
Copy link
Contributor

elmato commented Aug 8, 2023

We should also change the address recovery here:
https://github.com/eosnetworkfoundation/silkworm/blob/2b17748f46e7155638fee7589b274ce79b840aa5/silkworm/node/stagedsync/stages/stage_senders.cpp#L428C35-L428C56

Maybe we should encapsulate the logic in a new function here:

silkworm/silkworm/core/common/util.hpp

Line 157 in 2b17748

inline evmc::address make_reserved_address(uint64_t account) {

@arhag arhag dismissed their stale review August 8, 2023 17:03

Changes described above by Matias needed.

@yarkinwho yarkinwho requested a review from arhag August 9, 2023 03:37
@arhag arhag merged commit d661be9 into master Aug 14, 2023
@arhag arhag deleted the yarkin/recover_sender_new branch August 14, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arhag arhag arhag approved these changes

@elmato elmato elmato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yarkinwho @elmato @arhag